Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs-builder: introduce the confidential-containers-ci job #535

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

wainersm
Copy link
Contributor

@wainersm wainersm commented Mar 9, 2023

This introduces the confidential-containers-ci job which is going to monitor the kata-containers, kata-containers/tests and confidential-containers/operator for changes. Once any change is detected it will wait the runtime-payload-ci image for the kata-containers latest commit be built. Afterwards it triggers in parallel the Operator CI jobs which will leverage the new payload.

Currently it triggers only the non-TEE jobs for kata-qemu and kata-clh

I published the job manually yesterday (http://jenkins.katacontainers.io/job/confidential-containers-ci/). It seems to be working fine, at least the triggering, as the job 11 (http://jenkins.katacontainers.io/job/confidential-containers-ci/11/) ran on response to the changes merged on the kata-containers/tests repository.

Cc @fidencio @stevenhorsman

The introduced confidential-containers-ci job will be monitoring the
kata containers and operator repositories, and in case of changes it
will trigger children jobs to test the operator with the new runtime
payload.

Fixes kata-containers#534
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
With this change the "wait for images" stage will wait images for all
architectures which have at least one test job.

Fixes kata-containers#534
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Wainer, it looks like a great start to get some ci/cd. Some general thoughts (not blockers to merging this, just general observations on how we might extend/enhance this in future):

  • As mentioned in config: Update payloads to the latest CI image confidential-containers/operator#169 (comment) - maybe we could 'promote' the kata-runtime image that passes these tests to a new latest-tested tag, or similar, so we can always point to what we believe is a good payload image in the operator code base
  • Expand this to run different architectures/configurations when we get more capacity on machines
  • Work on the results - at the moment the clh & qemu tests are interleaved which is a bit tricky to follow but doable, if we expanded to add the sev, s390x then we might have more of a challenge

@wainersm
Copy link
Contributor Author

Hi @stevenhorsman !

Thanks for this Wainer, it looks like a great start to get some ci/cd. Some general thoughts (not blockers to merging this, just general observations on how we might extend/enhance this in future):

* As mentioned in [confidential-containers/operator#169 (comment)](https://github.com/confidential-containers/operator/pull/169#issuecomment-1462115900) - maybe we could 'promote' the kata-runtime image that passes these tests to a new `latest-tested` tag, or similar, so we can always point to what we believe is a good payload image in the operator code base

That's an interesting idea. Added an issue to track it: #537

* Expand this to run different architectures/configurations when we get more capacity on machines

It's on my roadmap for this job. I didn't add for sev and s390x yet because I am monitoring the job to see if it is stable. Added an issue too: #538

* Work on the results - at the moment the clh & qemu tests are interleaved which is a bit tricky to follow but doable, if we expanded to add the sev, s390x then we might have more of a challenge

Click on "Open Blue Ocean" link at left panel at http://jenkins.katacontainers.io/job/confidential-containers-ci/ . The blue ocean is like a revamp of Jenkins for pipeline jobs, it will have a much better view of the job. For example, http://jenkins.katacontainers.io/blue/organizations/jenkins/confidential-containers-ci/detail/confidential-containers-ci/15/pipeline , clicking on any step it will show the logs of only that step.

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @wainersm!

@wainersm wainersm merged commit 7041c90 into kata-containers:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants